[
https://issues.apache.org/jira/browse/CASSANDRA-14466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503544#comment-16503544
]
Ariel Weisberg commented on CASSANDRA-14466:
--------------------------------------------
I understand it's dependent on that to use direct IO. So a couple of things.
First is that you can implement all of this in JDK 8 without relying on the JDK
10 functionality at all. But even if you want to rely on the JDK 10
functionality if you use reflection you can get it building on JDK 8. This
patch isn't going to go into trunk any time soon if it doesn't build on JDK 8.
Another blocker is unit tests for the various new additional bits. Granted I
haven't reviewed it closely yet so I don't have specific feedback.
@benedict What do you think the bar should be for inclusion? Does the workload
that this improves justify the changes involved? The changes don't look that
bad to me, but I haven't reviewed it closely yet I just took a look at it to
see what changed and how big it was.
> Enable Direct I/O
> ------------------
>
> Key: CASSANDRA-14466
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14466
> Project: Cassandra
> Issue Type: New Feature
> Components: Local Write-Read Paths
> Reporter: Mulugeta Mammo
> Priority: Major
> Attachments: direct_io.patch
>
>
> Hi,
> JDK 10 introduced a new API for Direct IO that enables applications to bypass
> the file system cache and potentially improve performance. Details of this
> feature can be found at [https://bugs.openjdk.java.net/browse/JDK-8164900].
> This patch uses the JDK 10 API to enable Direct IO for the Cassandra read
> path. By default, we have disabled this feature; but it can be enabled using
> a new configuration parameter, enable_direct_io_for_read_path. We have
> conducted a Cassandra read-only stress test and measured a throughput gain of
> up to 60% on flash drives.
> The patch requires JDK 10 Cassandra Support -
> https://issues.apache.org/jira/browse/CASSANDRA-9608
> Please review the patch and let us know your feedback.
> Thanks,
> [^direct_io.patch]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
