[
https://issues.apache.org/jira/browse/CASSANDRA-9608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529779#comment-16529779
]
Robert Stupp commented on CASSANDRA-9608:
-----------------------------------------
Thanks for the feedback, [~jasobrown]
I've addressed the comments on the PR in a new commit on the branch and most
points in your comments above.
Regarding {{JMXServerUtils}}: I wanted to preserve the existing behavior, but I
agree that reflection itself is not "awesome". But should be addressed in a
separate ticket IMO.
Regarding the {{jvm*.options}} files: Moved the Java checks and related into
{{cassandra.in.sh}} and removed the {{clients.in.sh}} file(s). Also renamed the
server .options files - so we now have {{jvm*-clients.options}} and
{{jvm*-server.options}} files.
The changes for Windows are a bit difficult as I do not have a Windows box or
VM. Should we defer the Windows part to a follow-up ticket?
> Support Java 11
> ---------------
>
> Key: CASSANDRA-9608
> URL: https://issues.apache.org/jira/browse/CASSANDRA-9608
> Project: Cassandra
> Issue Type: Task
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
> Fix For: 4.x
>
> Attachments: jdk_9_10.patch
>
>
> This ticket is intended to group all issues found to support Java 9 in the
> future.
> From what I've found out so far:
> * Maven dependency {{com.sun:tools:jar:0}} via cobertura cannot be resolved.
> It can be easily solved using this patch:
> {code}
> - <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura"/>
> + <dependency groupId="net.sourceforge.cobertura"
> artifactId="cobertura">
> + <exclusion groupId="com.sun" artifactId="tools"/>
> + </dependency>
> {code}
> * Another issue is that {{sun.misc.Unsafe}} no longer contains the methods
> {{monitorEnter}} + {{monitorExit}}. These methods are used by
> {{o.a.c.utils.concurrent.Locks}} which is only used by
> {{o.a.c.db.AtomicBTreeColumns}}.
> I don't mind to start working on this yet since Java 9 is in a too early
> development phase.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
