[
https://issues.apache.org/jira/browse/CASSANDRA-14538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568332#comment-16568332
]
Aleksey Yeschenko commented on CASSANDRA-14538:
-----------------------------------------------
Code looks good. Fixed some nits here:
https://github.com/iamaleksey/cassandra/commits/caches_vtable_review
Missing license, inconsistent modifier order, stuff like that. Also gave things
(arguably) more descriptive names. If you are fine with those changes, I'll
commit, if not, we'd have to debate a little.
> Add virtual table to view cache information
> -------------------------------------------
>
> Key: CASSANDRA-14538
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14538
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Chris Lohfink
> Assignee: Chris Lohfink
> Priority: Minor
> Labels: virtual-tables
> Fix For: 4.0
>
>
> Add a table for displaying the general cache information (like in {{nodetool
> info}})
> {code}
> cqlsh> SELECT * FROM system_views.caches;
> name | entries | hit_ratio | hits | recent_hits_per_sec |
> recent_requests_per_sec | requests | size_max | size_used
> ---------+---------+-----------+------+---------------------+-------------------------+----------+----------+-----------
> counter | 0 | NaN | 0 | 0 |
> 0 | 0 | 12582912 | 0
> key | 19 | 0.922509 | 250 | 11 |
> 13 | 271 | 25165824 | 1728
> row | 0 | NaN | 0 | 0 |
> 0 | 0 | 16777216 | 0
> (3 rows)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
