[
https://issues.apache.org/jira/browse/CASSANDRA-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595423#comment-16595423
]
Dinesh Joshi commented on CASSANDRA-14656:
------------------------------------------
Hi [~krummas], I went through the patch and the change looks relatively
straightforward so I don't have a whole lot of feedback. There are a couple
things that you should address -
* {\{AuditLogManager::logBatch}}, \{{FullQueryLogger::logBatch}},
\{{FullQueryLogger::logQuery}}, \{{WeighableMarshallableBatch}} - Could you
update the Java doc comments for the new keyspace argument?
* {\{WeighableMarshallableQuery}} - Although the keyspace argument is treated
as \{{Nullable}}, I did not see a test case that exercises that code path.
Perhaps it is worth adding a test case with the keyspace as Null.
> Full query log needs to log the keyspace
> ----------------------------------------
>
> Key: CASSANDRA-14656
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14656
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Major
> Labels: fqltool
> Fix For: 4.x
>
>
> If the full query log is enabled and a set of clients have already executed
> "USE <ks>" we can't figure out which keyspace the following queries are
> executed against.
> We need this for CASSANDRA-14618
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
