[ https://issues.apache.org/jira/browse/CASSANDRA-14766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627448#comment-16627448 ]
Benedict commented on CASSANDRA-14766: -------------------------------------- one tiny nit: should probably set {{couldBeStartOfPartition = false}} outside of the {{if}} branch, so we don't unnecessarily perform the RT tests. It shouldn't have any impact besides possibly some probably immeasurable performance cost, but probably better that way. > DESC order reads can fail to return the last Unfiltered in the partition in a > legacy sstable > -------------------------------------------------------------------------------------------- > > Key: CASSANDRA-14766 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14766 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Major > Fix For: 3.0.x, 3.11.x > > > {{OldFormatDeserializer}}’s {{hasNext()}} method can and will consume two > {{Unfiltered}} from the underlying iterator in some scenarios - intentionally. > But in doing that it’s losing intermediate state of {{lastConsumedPosition}}. > If that last block, when iterating backwards, only has two {{Unfiltered}}, > the first one will be returned, and the last one won’t as the reverse > iterator would incorrectly things that the deserisalizer is past the index > block, despite still having one {{Unfiltered}} unreturned. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org