[ https://issues.apache.org/jira/browse/CASSANDRA-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629957#comment-16629957 ]
Alex Petrov edited comment on CASSANDRA-14742 at 9/27/18 8:47 AM: ------------------------------------------------------------------ Thank you, have addressed all three comments and took a liberty to introduce {{localDatacenter}} and {{localRack}} shortcuts, waiting for one more CI run. was (Author: ifesdjeen): Thank you, have addressed all three comments and took a liberty to introduce {{localDatacenter}} and {{localRack}} shortcuts. > Race Condition in batchlog replica collection > --------------------------------------------- > > Key: CASSANDRA-14742 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14742 > Project: Cassandra > Issue Type: Bug > Reporter: Alex Petrov > Assignee: Alex Petrov > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > When we collect nodes for it in {{StorageProxy#getBatchlogReplicas}}, we > already filter out down replicas; subsequently they get picked up and taken > for liveAndDown. > There's a possible race condition due to picking tokens from token metadata > twice (once in {{StorageProxy#getBatchlogReplicas}} and second one in > {{ReplicaPlan#forBatchlogWrite}}) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org