[ https://issues.apache.org/jira/browse/CASSANDRA-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650961#comment-16650961 ]
Blake Eggleston commented on CASSANDRA-14824: --------------------------------------------- looks good to me. The only think I might change would be to move the MERGED validator out of queryStorage and into executeLocally, which would validate the pre-purge stage for 2i implementations that may not be checking, but I don't feel strongly about it. > Expand range tombstone validation checks to multiple interim request stages > --------------------------------------------------------------------------- > > Key: CASSANDRA-14824 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14824 > Project: Cassandra > Issue Type: Improvement > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Major > Fix For: 3.0.x, 3.11.x, 4.0.x > > > {{RTBoundValidator}} was originally only added to verify the end-game > response iterator produced by {{ReadCommand}}. > However, turns out it's possible for sequencing errors in lower-level > iterators to be silently erased by upstream iterators - as a result of > merging two invalid iterators into one valid iterator, for example. > CASSANDRA-14823 can create such a scenario. > The upcoming patch would attach the checker at the intermediate stages, > ensuring that we can detect those otherwise silent corruptions. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org