[
https://issues.apache.org/jira/browse/CASSANDRA-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696118#comment-16696118
]
Aleksandr Sorokoumov commented on CASSANDRA-13917:
--------------------------------------------------
Thanks for feedback! I fixed indentation in tests, changed the check to report
all unmatching columns at once and rebased both branches.
I did not use {{superCfKeyColumn}} and {{superCfValueColumn}} because they are
null in the test case.
Created new branches:
* https://github.com/Gerrrr/cassandra/tree/13917-3.0
* https://github.com/Gerrrr/cassandra/tree/13917-3.11
CI results:
* [13917-3.0 |
https://issues.apache.org/jira/secure/attachment/12949215/13917-3.0.png]
* [13917-3.11 |
https://issues.apache.org/jira/secure/attachment/12949214/13917-3.11.png]
> COMPACT STORAGE inserts on tables without clusterings accept hidden column1
> and value columns
> ---------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-13917
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13917
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Alex Petrov
> Assignee: Aleksandr Sorokoumov
> Priority: Minor
> Labels: lhf
> Fix For: 3.0.x, 3.11.x
>
> Attachments: 13917-3.0.png, 13917-3.11.png
>
>
> Test for the issue:
> {code}
> @Test
> public void testCompactStorage() throws Throwable
> {
> createTable("CREATE TABLE %s (a int PRIMARY KEY, b int, c int) WITH
> COMPACT STORAGE");
> assertInvalid("INSERT INTO %s (a, b, c, column1) VALUES (?, ?, ?,
> ?)", 1, 1, 1, ByteBufferUtil.bytes('a'));
> // This one fails with Some clustering keys are missing: column1,
> which is still wrong
> assertInvalid("INSERT INTO %s (a, b, c, value) VALUES (?, ?, ?, ?)",
> 1, 1, 1, ByteBufferUtil.bytes('a'));
> assertInvalid("INSERT INTO %s (a, b, c, column1, value) VALUES (?, ?,
> ?, ?, ?)", 1, 1, 1, ByteBufferUtil.bytes('a'), ByteBufferUtil.bytes('b'));
> assertEmpty(execute("SELECT * FROM %s"));
> }
> {code}
> Gladly, these writes are no-op, even though they succeed.
> {{value}} and {{column1}} should be completely hidden. Fixing this one should
> be as easy as just adding validations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
