[ https://issues.apache.org/jira/browse/CASSANDRA-14716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699533#comment-16699533 ]
Aleksey Yeschenko commented on CASSANDRA-14716: ----------------------------------------------- I might be missing it, and probably am, but what is the reason for not simply doing {{ChecksumType.valueOf(name.toUpperCase)}}, and rethrowing {{IllegalArgumentException}} as {{ProtocolException}}? > Protocol frame checksumming options should not be case sensitive > ---------------------------------------------------------------- > > Key: CASSANDRA-14716 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14716 > Project: Cassandra > Issue Type: Bug > Components: CQL > Reporter: Sam Tunnicliffe > Assignee: Sam Tunnicliffe > Priority: Major > Fix For: 4.0 > > > Protocol v5 adds support for checksumming of native protocol frame bodies. > The checksum type is negotiated per-connection via the \{{STARTUP}} message, > with two types currently supported, Adler32 and CRC32. The mapping of the > startup option value requested by the client to a \{{ChecksumType}} should > not be case sensitive, but currently it is. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org