[
https://issues.apache.org/jira/browse/CASSANDRA-11323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702444#comment-16702444
]
Ariel Weisberg commented on CASSANDRA-11323:
--------------------------------------------
This is great. You can consolidate it to a single invocation to NoSpamLogger
before the switch statement? We only need the rate limiting for the ignore
case. In other cases it will only log once and the first time is guaranteed to
log.
For the NoSpamLogger the log string is the key used to track what log statement
is being rate limited. That means if you format the string and put in mutable
values like space required or free it is going to be multiple keys. The log
function accepts an argument list at the end that will be formatted in using
the sl4j syntax so the format string itself can be used as the key.
Can you change it to format that way so the key will be just the format string?
> When node runs out of commitlog space you get poor log information
> ------------------------------------------------------------------
>
> Key: CASSANDRA-11323
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11323
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
> Reporter: T Jake Luciani
> Assignee: Boris Onufriyev
> Priority: Trivial
> Labels: fallout
> Attachments: 11323-2.2.txt, 11323-3.0.txt, 11323-3.11.txt,
> 11323-trunk.txt
>
>
> {code}
> ERROR [PERIODIC-COMMIT-LOG-SYNCER] 2016-03-08 20:27:33,899
> StorageService.java:470 - Stopping gossiper
> WARN [PERIODIC-COMMIT-LOG-SYNCER] 2016-03-08 20:27:33,899
> StorageService.java:377 - Stopping gossip by operator request
> INFO [PERIODIC-COMMIT-LOG-SYNCER] 2016-03-08 20:27:33,899 Gossiper.java:1463
> - Announcing shutdown
> {code}
> That's all you get when a node runs out of commit log space.
> We should explicitly callout the fact the commitlog is out of disk. I see
> that in the commit log error handler but after it shuts down. So I think it's
> never getting written before shutdown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
