[
https://issues.apache.org/jira/browse/CASSANDRA-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725072#comment-16725072
]
Marcus Eriksson edited comment on CASSANDRA-14936 at 12/19/18 3:19 PM:
-----------------------------------------------------------------------
while fixing this up for commit I realised that we would be running the
PendingAntiCompactionTests twice with the Byteman tests I added
tiny refactor:
https://github.com/krummas/cassandra/commit/87c87a6a5554cfc82bc4fd10ea1d6dc5e67a20b2
https://circleci.com/workflow-run/7e383aaf-e96a-42d2-bbf9-866ced074df7
[~bdeggleston] could you just sanity check that before I commit?
was (Author: krummas):
while fixing this up for commit I realised that we would be running the
PendingAntiCompactionTests twice with the Byteman tests I added
tiny refactor:
https://github.com/krummas/cassandra/commit/be4ac7c39cd07b4484dc6e9c5617be4ebb22a338
https://circleci.com/workflow-run/ab2640cb-6655-4286-a1dd-6c4bf119a23a
[~bdeggleston] could you just sanity check that before I commit?
> Anticompaction should throw exceptions on errors, not just log them
> -------------------------------------------------------------------
>
> Key: CASSANDRA-14936
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14936
> Project: Cassandra
> Issue Type: Bug
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Major
> Fix For: 4.0
>
>
> Anticompaction currently catches any exceptions and just logs them instead of
> rethrowing, this can cause us to overstream and leave sstables unrepaired.
> This was made more likely to happen with CASSANDRA-14397 (before that
> anticompactions could not be stopped at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
