[
https://issues.apache.org/jira/browse/CASSANDRA-14395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769326#comment-16769326
]
Jason Brown commented on CASSANDRA-14395:
-----------------------------------------
- inspecting the tarball via produced via \{{gradlew distTar}}, I don't see the
jolokia jar packaged in it. Admittedly, I didn't check on the last version of
this patch either.
- need a license file when including the jolokia jar. I propose we start simple
for now, and since there's only one jar for now (which is hopefully being
removed in an upcoming patch) - just add the license in a subfolder like we do
in cassandra.
- in \{{HealthCheck::check}}, when we get a \{{NoHostAvailableException}} from
the driver (which is thrown when we cannot connect), it would preferable to not
litter the logs with the stack trace. Or maybe log the exception at \{{DEBUG}}
or \{{TRACE}}. I discovered this by running c* locally, then terminating it,
and watching the logs from the sidecar.
- petty nit: sometimes a \{{catch}} keyword is on the same line as the closing
brace of a \{[try}} block. See \{{HealhCheck::createCluster}} for an example.
> C* Management process
> ---------------------
>
> Key: CASSANDRA-14395
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14395
> Project: Cassandra
> Issue Type: New Feature
> Reporter: Dinesh Joshi
> Assignee: Dinesh Joshi
> Priority: Major
> Attachments: Looking towards an Official Cassandra Sidecar -
> Netflix.pdf
>
>
> I would like to propose amending Cassandra's architecture to include a
> management process. The detailed description is here:
> https://docs.google.com/document/d/1UV9pE81NaIUF3g4L1wxq09nT11AkSQcMijgLFwGsY3s/edit
> I'd like to propose seeding this with a few simple use-cases such as Health
> Checks, Bulk Commands with a simple REST API interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
