[
https://issues.apache.org/jira/browse/CASSANDRA-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795386#comment-16795386
]
Jordan West commented on CASSANDRA-15045:
-----------------------------------------
+1 with a few minor comments below.
* The change to check for global compactions makes sense. As usual, I want to
double check its ok to change the semantics in each of the versions the change
is proposed in. Are their any cases where it should be an option whether or not
global compactions are cancelled? My initial inclination is no but wanted to
bring it up explicitly regardless.
* Minor nit: IndexSummaryManager#L225, the variable name
“compactingAndNonCompacting” isn’t very descriptive after the changes
* Good catch re: the exception handling in redistributeSummaries() finally
block
* The refactor to use the pre-calculated size in IndexSummaryRedistribution is
much cleaner, thanks
> Fix index summary redistribution compaction cancellation issues
> ---------------------------------------------------------------
>
> Key: CASSANDRA-15045
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15045
> Project: Cassandra
> Issue Type: Bug
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x
>
>
> We can't cancel ongoing index summary redistributions currently due to
> {{CompactionInfo}} returning null for {{getTableMetadata/getCFMetaData}}
> [here|https://github.com/apache/cassandra/blob/67d613204fa4fb9584f11ec9886a0e7a0d622e92/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L1814]
> for index summary redistributions
> CASSANDRA-14935 also introduced a bug where we track the wrong sstables for
> index summary redistributions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
