[ 
https://issues.apache.org/jira/browse/CASSANDRA-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809564#comment-16809564
 ] 

Per Otterström commented on CASSANDRA-15076:
--------------------------------------------

One obvious and simple solution would of course be to just add a {{version}} at 
the start of the audit record header.

But we could also consider to change audit type value from {{AuditLog}} to 
{{audit}}.

A bit more invasive, but we might also consider to swap the order of the fields 
so we get:
{noformat}
type:<type>(text)
version:0(int16)
{noformat}

[~vinaykumarcse], what are our thoughts on this?


> Align record header of FQL and audit binary log
> -----------------------------------------------
>
>                 Key: CASSANDRA-15076
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15076
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/fql
>            Reporter: Per Otterström
>            Priority: Normal
>             Fix For: 4.0
>
>
> The new full query logger and the audit logger support logging into binary 
> Chronicle logs. Both create records with a small header to indicate what 
> follows, but the two features have adopted different header formats. Let's 
> align the record header format with this ticket.
>  * Both features should use the same header layout. This makes it possible to 
> give more user friendly error messages in the {{fqltool}} and 
> {{auditlogviewr}} commands.
>  * The record header should have a distinct {{type}} to indicate the type of 
> record.
>  * The record header should have a {{version}} so that the record format can 
> evolve.
> Current record header format of the FQL is:
> {noformat}
> version:0(int16)
> type:<type>(text)
> {noformat}
> where {{<type>}} can be either {{batch}} or {{single-query}}.
> Current record header format of the binary audit log is:
> {noformat}
> type:AuditLog(text)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to