[
https://issues.apache.org/jira/browse/CASSANDRA-15078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817932#comment-16817932
]
Alex Petrov commented on CASSANDRA-15078:
-----------------------------------------
[~bdeggleston] thank you for the patch. Just a couple of minor things:
* {{delegate}} calls can be placed right to the
{{DelegatingInvokableInstance}}. I know we might have placed some unnecessary
calls to {{AbstractCluster}} wrapper implementation, but we should take a
closer look and move them eventually.
* problem with {{sync}} call is that even though it runs on the instance
executor, it does not make sure we execute on the instance class loader. We
should use {{run|applyOnInstance}} instead. This is not the first time this
pops up and we should rethink {{IIsolatedExecutor}} interface or at least
document it to make sure we run in an appropriate context. Your instances of
usage are correct, since {{initializeRing}} is called from the right class
loader, but if we make those methods public, we should also make sure we use
the right class loader.
I'll make sure to track the changes that would make interface more intuitive,
but we probably will make them only after the messaging service refactor is
committed.
> Support cross version messaging in in-jvm upgrade dtests
> --------------------------------------------------------
>
> Key: CASSANDRA-15078
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15078
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
> Reporter: Blake Eggleston
> Assignee: Blake Eggleston
> Priority: Normal
> Fix For: 2.2.15, 3.0.19, 3.11.5, 4.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
