[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856488#comment-16856488
]
Dinesh Joshi edited comment on CASSANDRA-10190 at 6/5/19 8:22 AM:
------------------------------------------------------------------
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use "\{!r}" instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
was (Author: djoshi3):
Hi [~ptbannister], I have gone over your patch and here are some minor comments
-
{{cqlsh.py}}
* Why is {{FrozenType}} commented out?
* You've replaced occurrences of {{%r}} with {{"'{}'"}}. However, we should
use \{{"{!r}"}} instead which is equivalent to {{%r}}. Please remove the single
quotes surrounding the object names.
* Remove {{six}} import from L42. This is a premature import and breaks Python
2. {{six}} is imported on L150 once we have discovered the Python libraries
path for cqlsh.
* Python version check could be a bit more readable like this
{{sys.version_info.major != 3 and (sys.version_info.major == 2 and
sys.version_info.minor != 7)}} instead of using indexes.
{{copyutil.py}}
* L2514 remove commented out code.
{{cqlsh}}
* Nit: L51: python -> Python
> Python 3 support for cqlsh
> --------------------------
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
> Reporter: Andrew Pennebaker
> Assignee: Patrick Bannister
> Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
