[ https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcus Eriksson updated CASSANDRA-14772: ---------------------------------------- Test and Documentation Plan: unit tests + existing dtests Status: Patch Available (was: Open) Patch [here|https://github.com/apache/cassandra/compare/trunk...krummas:marcuse/14772?expand=1] and tests running [here|https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F14772] * Separates full query logging and audit logging - fql and audit logging now have no dependencies on each other, but both use {{BinLog}} to write log events to disk * Introduces {{QueryEvents}} + {{AuthEvents}} where it is possible to register listeners for these events * {{AuditLogManager}} and {{FullQueryLogger}} are now getting log events using these listeners * Introduces a small change in the {{QueryHandler}} interface - the {{process}} method now takes a parsed {{CQLStatement}} - this was done to avoid re-parsing the statement when logging and a {{parse}} method was added to create this {{CQLStatement}} * Move the {{enableFullQueryLogger}} etc methods from {{StorageProxy}} to {{StorageService}} > Fix issues in audit / full query log interactions > ------------------------------------------------- > > Key: CASSANDRA-14772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14772 > Project: Cassandra > Issue Type: Bug > Components: Legacy/CQL, Legacy/Tools > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Priority: Normal > Fix For: 4.0 > > > There are some problems with the audit + full query log code that need to be > resolved before 4.0 is released: > * Fix performance regression in FQL that makes it less usable than it should > be. > * move full query log specific code to a separate package > * do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs > {{BinAuditLogger}} wrong for example) > * avoid parsing the CQL queries twice in {{QueryMessage}} when audit log is > enabled. > * add a new tool to dump audit logs (ie, let fqltool be full query log > specific). fqltool crashes when pointed to them. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org