[
https://issues.apache.org/jira/browse/CASSANDRA-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894599#comment-16894599
]
Dinesh Joshi commented on CASSANDRA-10190:
------------------------------------------
Hi [~ptbannister], thanks for the changes and sorry about the slow responses on
my end. I had a few questions and comments regarding
[this|https://github.com/ptbannister/cassandra/commit/db10edd766f9d568f7df79f6d8cd16bc496dd6c3]
change.
I see you're trying to prevent a {{NoneType}} comparison. What test
specifically broke due to this change? Could you add a unit test to ensure that
this function works correctly with {{NoneType}} arguments? I want to also point
out that the behavior of this code is same under Python 2.7 and 3.6. Since
{{cassandra.metadata.Token}} implements {{__lt__()}} and {{__gt__()}} methods,
you will get an error if you try comparing it with {{NoneType}} so I'm a bit
puzzled why you needed this change. I agree that this piece of code is error
prone in the face of {{NoneType}} arguments and we should fix it. I'm just
trying to understand did we actually break something during migration?
Other than this question, the only feedback I have so far is to remove
commented out code from {{bin/cqlsh}}.
> Python 3 support for cqlsh
> --------------------------
>
> Key: CASSANDRA-10190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10190
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools
> Reporter: Andrew Pennebaker
> Assignee: Patrick Bannister
> Priority: Normal
> Labels: cqlsh
> Attachments: coverage_notes.txt
>
>
> Users who operate in a Python 3 environment may have trouble launching cqlsh.
> Could we please update cqlsh's syntax to run in Python 3?
> As a workaround, users can setup pyenv, and cd to a directory with a
> .python-version containing "2.7". But it would be nice if cqlsh supported
> modern Python versions out of the box.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
