[ 
https://issues.apache.org/jira/browse/CASSANDRA-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Eggleston updated CASSANDRA-15123:
----------------------------------------
    Status: Changes Suggested  (was: Review In Progress)

For trunk, I made a few adjustments to the CompactionTaskCollection class in a 
branch 
[here|https://github.com/bdeggleston/cassandra/tree/marcuse/15123-trunk], let 
me know what you think. The main motivation was improving how empty collections 
are created / identified to eliminate potential problems with instances created 
with empty / null collections, but I also renamed the class to be more 
consistent with our other extended collection classes.

For 3.11, we should either catch Throwable, or always call 
{{LifecycleTransaction#close}} in a finally block since it’s a noop on 
committed and aborted txns (my preference).

> Avoid keeping sstables marked compacting forever when user defined compaction 
> gets interrupted
> ----------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15123
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15123
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Compaction
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>
> When we have both repaired + unrepaired data on a node, we create multiple 
> compaction tasks and run them serially. If one of those tasks gets 
> interrupted or throws exception we will keep sstables in the other tasks as 
> compacting forever.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to