[ 
https://issues.apache.org/jira/browse/CASSANDRA-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900394#comment-16900394
 ] 

Benedict edited comment on CASSANDRA-15214 at 8/5/19 8:45 PM:
--------------------------------------------------------------

Sorry, I completely forgot to respond to this ticket so thanks for bumping it 
[~djoshi3]

>From my POV, including a C JVMTI agent is absolutely fine, [~jolynch].  We'd 
>have to take a closer look at jvmkill and jvmquake, and do our own brief audit 
>of the version we include to ensure it seems to behave reasonably.  But I 
>don't see any problem with utilising non-Java functionality.


was (Author: benedict):
Sorry, I completely forgot to respond to this ticket so thanks for bumping it 
[~djoshi3]

>From my POV, including a C JVMTI agent is absolutely fine.  We'd have to take 
>a closer look at jvmkill and jvmquake, and do our own brief audit of the 
>version we include to ensure it seems to behave reasonably.  But I don't see 
>any problem with utilising non-Java functionality.

> OOMs caught and not rethrown
> ----------------------------
>
>                 Key: CASSANDRA-15214
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15214
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Client, Messaging/Internode
>            Reporter: Benedict
>            Priority: Normal
>             Fix For: 4.0
>
>
> Netty (at least, and perhaps elsewhere in Executors) catches all exceptions, 
> so presently there is no way to ensure that an OOM reaches the JVM handler to 
> trigger a crash/heapdump.
> It may be that the simplest most consistent way to do this would be to have a 
> single thread spawned at startup that waits for any exceptions we must 
> propagate to the Runtime.
> We could probably submit a patch upstream to Netty, but for a guaranteed 
> future proof approach, it may be worth paying the cost of a single thread.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to