[ https://issues.apache.org/jira/browse/CASSANDRA-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908089#comment-16908089 ]
Benedict commented on CASSANDRA-15170: -------------------------------------- Thanks. Just a couple of tiny nits/questions: The {{synchronizedList}} wrapper: while its use is probably unnecessary (since the global event executor is single threaded), it is probably clearer and more future-proof. But perhaps it makes sense to only wrap the list for the time it is submitted as a consumer, e.g. {{synchronzedList(inboundExecutors)::add}}? Should {{IsolatedExecutor.shutdown]} invoke {{ExecutorUtils.awaitTermination}} to report a {{TimeoutException}}? > Reduce the time needed to release in-JVM dtest cluster resources after close > ---------------------------------------------------------------------------- > > Key: CASSANDRA-15170 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15170 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest > Reporter: Jon Meredith > Assignee: Jon Meredith > Priority: Normal > > There are a few issues that slow the in-JVM dtests from reclaiming metaspace > once the cluster is closed. > IsolatedExecutor issues the shutdown on a SingleExecutorThreadPool, sometimes > this thread was still running 10s after the dtest cluster was closed. > Instead, switch to a ThreadPoolExecutor with a core pool size of 0 so that > the thread executing the class loader close executes sooner. > If an OutboundTcpConnection is waiting to connect() and the endpoint is not > answering, it has to wait for a timeout before it exits. Instead it should > check the isShutdown flag and terminate early if shutdown has been requested. > In 3.0 and above, HintsCatalog.load uses java.nio.Files.list outside of a > try-with-resources construct and leaks a file handle for the directory. This > doesn't matter for normal usage, it leaks a file handle for each dtest > Instance created. > On trunk, Netty global event executor threads are still running and delay GC > for the instance class loader. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org