[
https://issues.apache.org/jira/browse/CASSANDRA-15228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedict updated CASSANDRA-15228:
---------------------------------
Description: Under default commit log configuration, the sync markers have
no purpose, only serving to reduce persistence by preventing replay of any
mutations serialised between syncs. Refactoring the commit log to prevent this
would be painful, given their utility for encrypted and compressed segments, so
we should instead ignore the lack of a final sync marker when replaying a raw
commit log segment, and attempt to replay any mutations we encounter after the
last sync marker. (was: The sync markers existed to permit file re-use. Since
we no longer re-use files, they no longer provide any value. However, they
_can_ corrupt the commit log for replay in the event of a process crash.
Before we release 4.0, we should ideally remove the sync markers entirely.
)
> CommitLogReplayer should replay past final sync marker
> ------------------------------------------------------
>
> Key: CASSANDRA-15228
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15228
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
> Reporter: Benedict
> Priority: Normal
> Fix For: 4.0.x
>
>
> Under default commit log configuration, the sync markers have no purpose,
> only serving to reduce persistence by preventing replay of any mutations
> serialised between syncs. Refactoring the commit log to prevent this would
> be painful, given their utility for encrypted and compressed segments, so we
> should instead ignore the lack of a final sync marker when replaying a raw
> commit log segment, and attempt to replay any mutations we encounter after
> the last sync marker.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
