[
https://issues.apache.org/jira/browse/CASSANDRA-14772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921337#comment-16921337
]
Aleksey Yeschenko commented on CASSANDRA-14772:
-----------------------------------------------
Good stuff.
1. Would prefer if {{QueryEvents#startTime()}} weren’t conditional on listeners
size; this, coupled with the {{time > 0}} check conflates the two concerns
(current timestamp and presence of listereners)
2. Following up on that, would prefer if the {{time > 0}} check was gone from
{{QueryEvents#notify*}} methods; instead, to prevent potential allocation of a
capturing lambda with empty listeners, replace {{listeners#forEach()}} calls
with for-each loops
3. Minor, but I don’t see why {{getInstance()}} method exists in
{{QueryEvents}} and {{AuthEvents}}. It has no value and goes against our
guidelines (prefer public final fields to getter methods) and precedent (public
static {{INSTANCE}} singletons)
4. {{AuditLogManager#executeFailure()}} - there are to {{toString()}} calls for
{{setOperation()}}; Seem to not be intentional to me?
5. {{IAuditLogger#path()}} method should be removed; nit: rename {{enabled()}}
to a proper predicate name like {{isEnabled()}}?
> Fix issues in audit / full query log interactions
> -------------------------------------------------
>
> Key: CASSANDRA-14772
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14772
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL, Legacy/Tools
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.0, 4.0-rc
>
>
> There are some problems with the audit + full query log code that need to be
> resolved before 4.0 is released:
> * Fix performance regression in FQL that makes it less usable than it should
> be.
> * move full query log specific code to a separate package
> * do some audit log class renames (I keep reading {{BinLogAuditLogger}} vs
> {{BinAuditLogger}} wrong for example)
> * avoid parsing the CQL queries twice in {{QueryMessage}} when audit log is
> enabled.
> * add a new tool to dump audit logs (ie, let fqltool be full query log
> specific). fqltool crashes when pointed to them.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
