[ https://issues.apache.org/jira/browse/CASSANDRA-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938464#comment-16938464 ]
Michael Semb Wever commented on CASSANDRA-14655: ------------------------------------------------ bq. Made changes to remove nativePort parameter from NativeSSTableLoaderClient's constructor. LoaderOptions.Builder.build() already puts nativePort into the hosts (line 152), so I didn't have to make any changes there - please let me know in case I missed out anything here. Line 152 is only adding the default nativePort onto the {{hostArgs}} array, but that array is not parsed anymore (it's only part of a deprecated setter). The newer {{hosts}} array, which accepts custom ports, does add the default nativePort if need be, ref line 376. But a problem here is that the default {{nativePort}} is not parsed until later on, ref line 432. bq. Status of Tests (https://circleci.com/workflow-run/6ff402e1-a68b-4092-bc6a-62b10cc36d2d) Thanks for that! It really is crap that travis is so flakey and circleci only works with paid accounts and lots of containers. > Upgrade C* to use latest guava (27.0) > ------------------------------------- > > Key: CASSANDRA-14655 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14655 > Project: Cassandra > Issue Type: Improvement > Components: Dependencies > Reporter: Sumanth Pasupuleti > Assignee: Sumanth Pasupuleti > Priority: Low > Labels: 4.0-feature-freeze-review-requested > Fix For: 4.x > > > C* currently uses guava 23.3. This JIRA is about changing C* to use latest > guava (26.0). Originated from a discussion in the mailing list. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org