[
https://issues.apache.org/jira/browse/CASSANDRA-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950744#comment-16950744
]
Vinay Chella edited comment on CASSANDRA-15076 at 10/14/19 6:28 AM:
--------------------------------------------------------------------
First pass of review:
* {{AuditLogViewer::verifyVersion}} and {{AuditLogViewer::readType}} are
throwing runtime exceptions in case of unexpected format and unsupported
versions. However, when reading log files with thousands of records, earlier
schematics were to ignore those records. Are we stopping the processing of the
audit log in new schematics? If so, It might be better to log warnings for
those specific records (_if needed)_ and move on with processing rather than
aborting the viewer.
* nitpick/idea: Would {{int16}} be the right choice for version? Can we be
aggressive to {{int8}}?
Can you also rebase your changes on the latest trunk?
was (Author: vinaykumarcse):
First pass of review:
* {{AuditLogViewer::verifyVersion}} and {{AuditLogViewer::readType}} are
throwing runtime exceptions in case of unexpected format and unsupported
versions. When reading log files with thousands of records, earlier schematics
were to ignore those records, but with new schematics, are we stopping the
processing of the audit log? If so, It might be better to log warnings for
those specific records (_if needed)_ and move on rather than aborting the
viewer.
* nitpick/idea: Would {{int16}} be the right choice for version? Can we be
aggressive to {{int8}}?
Can you also rebase your changes on the latest trunk?
> Align record header of FQL and audit binary log
> -----------------------------------------------
>
> Key: CASSANDRA-15076
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15076
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools, Tool/fql
> Reporter: Per Otterström
> Assignee: Per Otterström
> Priority: Normal
> Fix For: 4.0
>
>
> The new full query logger and the audit logger support logging into binary
> Chronicle logs. Both create records with a small header to indicate what
> follows, but the two features have adopted different header formats. Let's
> align the record header format with this ticket.
> * Both features should use the same header layout. This makes it possible to
> give more user friendly error messages in the {{fqltool}} and
> {{auditlogviewr}} commands.
> * The record header should have a distinct {{type}} to indicate the type of
> record.
> * The record header should have a {{version}} so that the record format can
> evolve.
> Current record header format of the FQL is:
> {noformat}
> version:0(int16)
> type:<type>(text)
> {noformat}
> where {{<type>}} can be either {{batch}} or {{single-query}}.
> Current record header format of the binary audit log is:
> {noformat}
> type:AuditLog(text)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
