[ 
https://issues.apache.org/jira/browse/CASSANDRA-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sam Tunnicliffe updated CASSANDRA-15365:
----------------------------------------
    Status: Ready to Commit  (was: Review In Progress)

LGTM (just needs the JIRA # adding to the comment at {{LegacyLayout#1245}})

> Add primary key liveness info when skipping illegal cells
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-15365
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15365
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/SSTable
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x
>
>
> In CASSANDRA-15086/CASSANDRA-15178 we started skipping the illegal legacy 
> cells, problem is that if the row only contains illegal cells, we return a 
> totally empty row which breaks stats collection: 
> https://github.com/apache/cassandra/blob/93815db9853cb592edf13d82e91dc2e9d172f01f/src/java/org/apache/cassandra/db/rows/Rows.java#L70
> If the row only has these invalid cells, we should add a primary key liveness 
> info to it to match the 2.1 behaviour.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to