[
https://issues.apache.org/jira/browse/CASSANDRA-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962085#comment-16962085
]
Per Otterström commented on CASSANDRA-15076:
--------------------------------------------
I've rebased the patch on latest trunk and added the -i flag as discussed above.
[PR|https://github.com/apache/cassandra/pull/372]
[Tests|https://circleci.com/workflow-run/9ecd0d8b-7d3b-4b0b-a3f1-089d1126ce89]
A local run of the auditlog_test.py and fqltool_test.py dtests is OK. Also, I
did some manual verification on a ccm cluster.
{quote}Please create a ticket so that we can follow up on this as well.
{quote}
Created CASSANDRA-15384 to follow up on disk space improvements.
> Align record header of FQL and audit binary log
> -----------------------------------------------
>
> Key: CASSANDRA-15076
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15076
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Tools, Tool/fql
> Reporter: Per Otterström
> Assignee: Per Otterström
> Priority: Normal
> Fix For: 4.0
>
>
> The new full query logger and the audit logger support logging into binary
> Chronicle logs. Both create records with a small header to indicate what
> follows, but the two features have adopted different header formats. Let's
> align the record header format with this ticket.
> * Both features should use the same header layout. This makes it possible to
> give more user friendly error messages in the {{fqltool}} and
> {{auditlogviewr}} commands.
> * The record header should have a distinct {{type}} to indicate the type of
> record.
> * The record header should have a {{version}} so that the record format can
> evolve.
> Current record header format of the FQL is:
> {noformat}
> version:0(int16)
> type:<type>(text)
> {noformat}
> where {{<type>}} can be either {{batch}} or {{single-query}}.
> Current record header format of the binary audit log is:
> {noformat}
> type:AuditLog(text)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
