[ 
https://issues.apache.org/jira/browse/CASSANDRA-15349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968468#comment-16968468
 ] 

Chris Lohfink commented on CASSANDRA-15349:
-------------------------------------------

I guess I can see it going either way of a new opcode or a new REGISTER event 
type. Id personally lean towards a new opcode and message.

My impression was that the REGISTER events was for cluster things (so far that 
even the Cluster in java driver is the thing registered as the handler) so 
overloading with this might not be as clean as just creating a new message 
type. Although Ive only looked at the 3.x version of driver so perhaps the 4.x 
branch has something to make registering for events more separate from cluster 
events. We kinda need to bump protocol version anyway I believe (are there 
other new cql features or protocol changes in the works? maybe worth creating a 
parent JIRA) on the server to determine if we can send the "GOING_AWAY" message 
although we could probably just fudge it and list as v4 since client wont 
request it if it cant deserialize it.

> Add “Going away” message to the client protocol
> -----------------------------------------------
>
>                 Key: CASSANDRA-15349
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15349
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Messaging/Client
>            Reporter: Alex Petrov
>            Priority: Normal
>              Labels: client-impacting
>
> Add “Going away” message that allows node to announce its shutdown and let 
> clients gracefully shutdown and not attempt further requests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to