[
https://issues.apache.org/jira/browse/CASSANDRA-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992778#comment-16992778
]
Yifan Cai commented on CASSANDRA-15429:
---------------------------------------
Thanks [~ifesdjeen]
{quote}Can we hide nodetool behind a feature flag, same as native transport and
other things?
{quote}
There are two reasons that I think nodetool does not need a feature flag.
# {{nodetool}} only consumes resources when being invoked, and the resources
are released once the call exit. On instance startup, we only replace the
implementation of nodetool probe (to the internal one).
# A new method {{nodetool}} is added in {{IInstance}}, and use the
mock/internal node probe at the instance impl. If a feature flag is introduced,
the behavior when the nodetool feature is disabled and calling {{nodetool}}
method could be confusing. Because, the actual node probe cannot connect to the
JVM cluster instances.
{quote}a TODO about GCInspector, can you elaborate a bit?
{quote}
Nice catch! The TODO should be removed. The patch does not support the nodetool
commands that are used to print information to stdout, e.g. GCInspector, which
is used to print the gc stats. The text to stdout is less useful for jvm dtest.
I have removed the todo and rebased the branches onto the latest.
> Support NodeTool for in-jvm dtest
> ---------------------------------
>
> Key: CASSANDRA-15429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15429
> Project: Cassandra
> Issue Type: New Feature
> Components: Test/dtest
> Reporter: Yifan Cai
> Assignee: Yifan Cai
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In-JVM dtest framework does not support nodetool as of now. This
> functionality is wanted in some tests, e.g. constructing an end-to-end test
> scenario that uses nodetool.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
