[
https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010954#comment-17010954
]
Venkata Harikrishna Nukala commented on CASSANDRA-14781:
--------------------------------------------------------
[~jrwest] Made the changes.
Here is the [updated
patch|https://github.com/nvharikrishna/cassandra/commit/1eb9a9846187f669516c88c85fa3550e4efb08f7]
and [CI|https://app.circleci.com/jobs/github/nvharikrishna/cassandra/120].
Summary of changes:
* Removed SizeHolder
* MutationExceededMaxSizeException
** Avoided calculating size again.
** Changed constant for limiting no.of keys to size of the message. We are
mostly concerned about dumping huge message to log. No.of keys to log has to
vary based on its size and there won't be an ideal config by no.of keys. So
changed it to message size (1kb for now, we can increase it further).
* IMutation
** removed getMaxMutationSize and replaced it with constant from CommitLog.
* Replaced Mutation.serializer.serializedSize with mutation.serializedSize.
> Log message when mutation passed to CommitLog#add(Mutation) is too large is
> not descriptive enough
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-14781
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14781
> Project: Cassandra
> Issue Type: Bug
> Components: Consistency/Hints, Local/Commit Log, Messaging/Client
> Reporter: Jordan West
> Assignee: Tom Petracca
> Priority: Normal
> Labels: protocolv5
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch,
> CASSANDRA-14781_3.11.patch
>
>
> When hitting
> [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257],
> the log message produced does not help the operator track down what data is
> being written. At a minimum the keyspace and cfIds involved would be useful
> (and are available) – more detail might not be reasonable to include.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
