[
https://issues.apache.org/jira/browse/CASSANDRA-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013903#comment-17013903
]
Yifan Cai commented on CASSANDRA-15499:
---------------------------------------
The code change is minor. Trace headers are added when tracing is on and no
trace headers are present.
[PR|https://github.com/apache/cassandra/pull/422],
[Code|https://github.com/yifan-c/cassandra/tree/CASSANDRA-15499] and
[Test|https://app.circleci.com/github/yifan-c/cassandra/pipelines/3df93bc8-f10e-44bc-884f-767da032a862/workflows/6ee3bd5c-98a1-44f0-9889-21a1ec77bebd]
> Internode message builder does not add trace header
> ---------------------------------------------------
>
> Key: CASSANDRA-15499
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15499
> Project: Cassandra
> Issue Type: Bug
> Components: Messaging/Internode
> Reporter: Yifan Cai
> Assignee: Yifan Cai
> Priority: Normal
>
> The messages built with the {{Builder}}
> ({{org.apache.cassandra.net.Message.Builder}}) do not have the trace header
> when tracing is enabled.
> Consequently, no tracing session gets propagated to other nodes, and the
> tracing function is broken.
> The set of static {{out*}} methods provided (to create an out-bounding
> message) in Message do not have the issue. They can properly add the trace
> header when necessary.
> To be clear, only the {{Builder}} missed adding the tracing header and it
> should be fixed to be consistent with the {{out*}} methods.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
