[ https://issues.apache.org/jira/browse/CASSANDRA-15470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018746#comment-17018746 ]
Mallika Kulkarni commented on CASSANDRA-15470: ---------------------------------------------- Jordan West, Thanks for catching it. I corrected the typo. I also corrected the units in the error messages. The {{DatabaseDescriptor::getNativeTransportMaxFrameSize}} returns the {{conf.native_transport_max_frame_size_in_mb}} field multiplied by (1024 * 1024). 2GiB == (2 * 1024 * 1024 * 1024) == ({{Integer.MAX_VALUE}} + 1) for a 4 byte unsigned integer in java Therefore, an input for {{native_transport_max_frame_size_in_mb}} has to be less than (2 * 1024) > Potential Overflow in DatabaseDescriptor Functions That Convert Between KB/MB > & Bytes > ------------------------------------------------------------------------------------- > > Key: CASSANDRA-15470 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15470 > Project: Cassandra > Issue Type: Bug > Components: Local/Config > Reporter: Jordan West > Assignee: Mallika Kulkarni > Priority: Normal > Labels: pull-request-available > Fix For: 4.0-rc > > Time Spent: 10m > Remaining Estimate: 0h > > {{DatabaseDescriptor}} has several functions that convert between user > supplied sizes in KB/MB and bytes. These are implemented without much > consistency and, while unlikely, several have the potential to overflow since > validation on the input is missing. Meanwhile, some widen the number to a > long correctly. Options include: widening in all places or simply doing > better validation on start up — currently only the lower bound of the valid > range is checked for many of these fields. > List of Affected {{DatabaseDescriptor}} Methods: > * {{getColumnIndexSize}} > * {{getColumnIndexCacheSize}} > * {{getBatchSizeWarnThreshold}} > * {{getNativeTransportFrameBlockSize}} > * {{getRepairSessionSpaceInMegabytes}} > * {{getNativeTransportMaxFrameSize}} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org