[ 
https://issues.apache.org/jira/browse/CASSANDRA-15509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020452#comment-17020452
 ] 

David Capwell commented on CASSANDRA-15509:
-------------------------------------------

LGTM +1

 

Testing done outside of circle:

 

{code}

$ jshell
Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
| Welcome to JShell -- Version 11.0.2
| For an introduction type: /help intro

jshell> import java.util.regex.Pattern

jshell> Pattern pattern = 
Pattern.compile("dtest-(?<fullversion>(\\d+)\\.(\\d+)(\\.\\d+)?(\\.\\d+)?)([~\\-]\\w[.\\w]*(?:\\-\\w[.\\w]*)*)?(\\+[.\\w]+)?\\.jar");
pattern ==> dtest-(?<fullversion>(\d+)\.(\d+)(\.\d+)?(\.\d+)? ... 
[.\w]*)*)?(\+[.\w]+)?\.jar

jshell> var m = pattern.matcher("dtest-4.0-alpha3.jar")
m ==> java.util.regex.Matcher[pattern=dtest-(?<fullvers ... ar region=0,20 
lastmatch=]

jshell> m.matches()
$9 ==> true

jshell> m.group("fullversion")
$10 ==> "4.0"

jshell> var m = pattern.matcher("dtest-4.0.0.1-alpha3.jar")
m ==> java.util.regex.Matcher[pattern=dtest-(?<fullvers ... ar region=0,24 
lastmatch=]

jshell> m.matches()
$12 ==> true

jshell> m.group("fullversion")
$13 ==> "4.0.0.1"

{code}

> In-jvm upgrade dtest version parsing does not support 4.0 alpha/beta/rc builds
> ------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15509
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15509
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>
> for example:
> https://circleci.com/gh/krummas/cassandra/2686



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to