[
https://issues.apache.org/jira/browse/CASSANDRA-15486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029635#comment-17029635
]
Joey Lynch edited comment on CASSANDRA-15486 at 2/4/20 8:22 AM:
----------------------------------------------------------------
Hi [~dvohra] thank you for contributing this, it is a really good starting
point!
I've put up some initial edits on my
[review/dynamo|https://github.com/jolynch/cassandra/tree/review/dynamo] branch,
you can view the [diff so far
|https://github.com/dvohra/cassandra/compare/dynamo...jolynch:review/dynamo]
I'm still working through all the sections but just a few high level pieces of
feedback:
* I think that some of the information about scale and general motivation
should move to the overview section. I've moved some of it here but I know that
there is an in flight PR for the overview as well that we may need to merge in.
* I have tried to suggest some edits along the lines of relating how Cassandra
uses Dynamo, as opposed to describing Dynamo. For example I think explaining
data versioning is a tad counterproductive since Cassandra doesn't use it.
* I made two new diagrams to show the ring and vnode setups, let me know what
you think of the changes.
I will try to get through the rest of the sections tomorrow, if you want to
pull in some or all of my changes and squash down I would appreciate that.
Thank you again!
was (Author: jolynch):
Hi [~dvohra] thank you for contributing this, it is a really good starting
point!
I've put up some initial edits on my
[review/dynamo|https://github.com/jolynch/cassandra/tree/review/dynamo] branch,
you can view the [diff so far
|https://github.com/dvohra/cassandra/compare/dynamo...jolynch:review/dynamo]
I'm still working through all the sections but just a few high level pieces of
feedback:
* I think that some of the information about scale and general motivation
should move to the overview section. I've moved some of it here but I know that
there is an in flight PR for the overview as well that we may need to merge in.
* I have tried to suggest some edits along the lines of relating how Cassandra
uses Dynamo, as opposed to describing Dynamo. For example I think explaining
data versioning is a tad counterproductive since Cassandra doesn't use it.
* I made two new diagrams to show the ring and vnode setups, let me know what
you think of the changes.
> Dynamo
> ------
>
> Key: CASSANDRA-15486
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15486
> Project: Cassandra
> Issue Type: Sub-task
> Components: Documentation/Website
> Reporter: DeepakVohra
> Assignee: DeepakVohra
> Priority: Normal
>
> Added new sections to Dynamo page.
> https://github.com/apache/cassandra/pull/415
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
