[ https://issues.apache.org/jira/browse/CASSANDRA-14737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030509#comment-17030509 ]
Ryan Svihla commented on CASSANDRA-14737: ----------------------------------------- +1 I applied the patch to a recent trunk and the builds are passing locally with the exception of some of the dtests but those have all been flakey. I can't see any downside to applying the patch and it'd be nice to separate this out. > Limit the dependencies used by UDFs/UDAs > ---------------------------------------- > > Key: CASSANDRA-14737 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14737 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/CQL > Reporter: Robert Stupp > Assignee: Robert Stupp > Priority: Low > Labels: UDF > Fix For: 4.0 > > > In an effort to clean up our hygiene and limit the dependencies used by > UDFs/UDAs, I think we should refactor the UDF code parts and remove the > dependency to the Java Driver in that area without breaking existing > UDFs/UDAs. > > The patch is in [this > branch|https://github.com/snazy/cassandra/tree/feature/remove-udf-driver-dep-trunk]. > The changes are rather trivial and provide 100% backwards compatibility for > existing UDFs. > > The prototype copies the necessary parts from the Java Driver into the C* > source tree to {{org.apache.cassandra.cql3.functions.types}} and adopts its > usages - i.e. UDF/UDA code plus {{CQLSSTableWriter}} + > {{StressCQLSSTableWriter}}. The latter two classes have a reference to UDF's > {{UDHelper}} and had to be changed as well. > > Some functionality, like type parsing & handling, is duplicated in the code > base with this prototype - once in the "current" source tree and once for > UDFs. However, unifying the code paths is not trivial, since the UDF sandbox > prohibits the use of internal classes (direct and likely indirect > dependencies). > > /cc [~jbellis] > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org