[
https://issues.apache.org/jira/browse/CASSANDRA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032249#comment-17032249
]
Jordan West edited comment on CASSANDRA-15556 at 2/7/20 9:39 AM:
-----------------------------------------------------------------
Thanks [~dcapwell] -- appreciate the benchmarks and new unit test! Patch looks
good overall. A couple comments:
* I think we need to update the dependency in {{lib}} as well.
* Minor nit: any reason I'm missing why the test can't be included in the
existing class (it already has some unit tests)?
Also re:
bq. it has been fixed already for sstables it seems.
I agree they are separate code paths but it looks like we are still using
{{FastDecompressor}} in
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/compress/LZ4Compressor.java#L75
was (Author: jrwest):
Thanks [~dcapwell]. Patch overall looks good a couple comments:
* I think we need to update the dependency in {{lib}} as well.
* Minor nit: any reason I'm missing why the test can't be included in the
existing class (it already has some unit tests)?
Also re:
bq. it has been fixed already for sstables it seems.
I agree they are separate code paths but it looks like we are still using
{{FastDecompressor}} in
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/compress/LZ4Compressor.java#L75
> When a LZ4 stream is corrupted it could cause the JVM to crash
> --------------------------------------------------------------
>
> Key: CASSANDRA-15556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15556
> Project: Cassandra
> Issue Type: Sub-task
> Components: Messaging/Client
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0-alpha
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is a spin off of CASSANDRA-15313 and CASSANDRA-15299
> This was found when lz4 sees compressed data (not all, but happens) which is
> corrupted; in some cases the JVM crashes producing the following
> {code}
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> # SIGBUS (0xa) at pc=0x0000000110d46ad1, pid=86555, tid=0x0000000000001103
> #
> # JRE version: OpenJDK Runtime Environment (8.0_222-b10) (build 1.8.0_222-b10)
> # Java VM: OpenJDK 64-Bit Server VM (25.222-b10 mixed mode bsd-amd64
> compressed oops)
> # Problematic frame:
> # C [liblz4-java2766366422904460658.dylib+0x3ad1] LZ4_decompress_fast+0xf1
> #
> # Failed to write core dump. Core dumps have been disabled. To enable core
> dumping, try "ulimit -c unlimited" before starting Java again
> #
> # An error report file with more information is saved as:
> # /Users/davidcapwell/src/github/apache/cassandra/hs_err_pid86555.log
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
