[ 
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040573#comment-17040573
 ] 

David Capwell edited comment on CASSANDRA-15553 at 2/20/20 2:06 AM:
--------------------------------------------------------------------

Yeah, that complicates things a little bit, would need to think about it more.


was (Author: dcapwell):
That would be fine; min is still smaller than the max one seen, so that 
wouldn't break the snapshot isolation.

> Preview repair should include sstables from finalized incremental repair 
> sessions
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15553
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15553
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Repair
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 4.0-alpha
>
>
> When running a preview repair we currently grab all repaired sstables, 
> problem is that we depend on compaction to move the sstables from pending to 
> repaired so we might have different data marked repaired on different nodes. 
> Including any sstables from finalized incremental repair sessions as repaired 
> will solve this.
> Another problem is that validations don't start at exactly the same time on 
> different nodes, so if an incremental repair finishes while the preview 
> repair is running we might also validate the wrong repaired set. We should 
> fail the preview repair if an intersecting incremental repair finishes during 
> the preview repair.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to