[ 
https://issues.apache.org/jira/browse/CASSANDRA-15567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Capwell updated CASSANDRA-15567:
--------------------------------------
    Status: Changes Suggested  (was: Review In Progress)

Yep, confirmed our packaging puts this at the end: 
https://github.com/apache/cassandra/blob/trunk/redhat/cassandra.in.sh#L22. 

Also finished testing on trunk (sorry, got distracted)

{code}
git pull --rebase upstream trunk
curl 
https://github.com/apache/cassandra/compare/trunk...driftx:CASSANDRA-15567.diff 
| patch -p1
patch -p1 < debian/patches/cassandra_in.sh_dirs.diff
{code}

This then produced the following

{code}
...
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"

for jar in "$CASSANDRA_HOME"/*.jar; do
    CLASSPATH="$CLASSPATH:$jar"
done

# Include EXTRA_CLASSPATH from /etc/default/cassandra
CLASSPATH="$CLASSPATH:$EXTRA_CLASSPATH"
...
{code}

That could cause a problem, so can we update the diff so we don't double add 
the EXTRA_CLASSPATH?  Looks like redhat forks the file so only need to worry 
about this with Debian?


[~brandon.williams] if you move to the end of the class path and update debian 
then i'm +1

> Allow EXTRA_CLASSPATH to work in tarball/source installations
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-15567
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15567
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Scripts
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0-beta
>
>
> Both the debian and redhat packaging modify cassandra.in.sh to support the 
> EXTRA_CLASSPATH variable.  It would be nice to just put this in 
> cassandra.in.sh proper so people without a package installation can use it as 
> well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to