[ https://issues.apache.org/jira/browse/CASSANDRA-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jordan West updated CASSANDRA-15256: ------------------------------------ Status: Ready to Commit (was: Review In Progress) LGTM. +1. Some notes for future readers: {{getReplicas}}: - Was added as part of Transient Replication patch (CASSANDRA-14404) - Eventually calls {{getNaturalReplicasForToken(String, ByteBuffer)}} function just like {{getNaturalEndpoints}} does but with an additional check that the table exists (although it uses no metadata from this table) - Does not include ports like {{getendpoints}} does. Although {{getendpoints}} uses the deprecated method {{getNaturalEndpoints}} it has an option to use the replacement {{getNaturalEndpointsWithPort}} Other Changes: - HandoffWindow (added in CASSANDRA-13728) was duplicate of GetMaxHintWindow (added in CASSANDRA-11720) which is more conventional naming - Removes duplicate DisableAuditLog listing > Clean up redundant nodetool commands added in 4.0 > ------------------------------------------------- > > Key: CASSANDRA-15256 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15256 > Project: Cassandra > Issue Type: Improvement > Components: Tool/nodetool > Reporter: Chris Lohfink > Assignee: Chris Lohfink > Priority: Low > Fix For: 4.0 > > > Both hintedhandoff and getendpoints had a 2nd command added that does the > exact thing but rewritten (and in getReplicas not as well) not just aliased > (like cf->tablestats). Also a minor cleanup is same command added multiple > times to nodetool command list. We should clean this up before 4.0 release > before people become reliant on the newly introduced command name. If we want > them renamed as that we should rename and link with alias like we do with > cf->table others. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org