[
https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050658#comment-17050658
]
David Capwell commented on CASSANDRA-15564:
-------------------------------------------
thanks for the feedback! Ill try to address everything tomorrow but there is
one I want to address sooner.
bq. setting creationTimeMillies in the ctor is going to change how repair times
are reported in some cases, since there may be a significant delay between
runnable creation and starting in some cases. It would be good to also report
this, which I don't think we do
Yes, this is now "response time" where as before it was "service time"; this is
actually split in the parent JIRA and is more fine grain (each transition is
stored separately and exposed, also know the last time "progress" was seen).
bq. but we shouldn't combine them, since they can each reveal different
problems.
I agree they show different problems, I guess to me I see this as "who should
view this KPI" which should be the users operating the cluster, and I "feel"
"response time" is actually better. I would hate to change this, but it is a
change in behavior that isn't fully needed in this patch (and the parent JIRA
gives more fine grain detail anyway)...
[~clohfink] thoughts here? Until CASSANDRA-15399 is in which would you prefer?
> Refactor repair coordinator so errors are consistent
> ----------------------------------------------------
>
> Key: CASSANDRA-15564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15564
> Project: Cassandra
> Issue Type: Sub-task
> Components: Consistency/Repair
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> This is to split the change in CASSANDRA-15399 so the refactor is isolated
> out.
> Currently the repair coordinator special cases the exit cases at each call
> site; this makes it so that errors can be inconsistent and there are cases
> where proper complete isn't done (proper notifications, and forgetting to
> update ActiveRepairService).
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
