[
https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051515#comment-17051515
]
David Capwell edited comment on CASSANDRA-15564 at 3/4/20, 6:46 PM:
--------------------------------------------------------------------
org.apache.cassandra.distributed.test.PreviewRepairTest uses a blocking filter
to delay the validation message; in trunk we block the MessagingService.send
method and in this patch we do this as part of inbound filtering (this is
performed in the Stage pool, for repair this is size 1). In order for dtest
filters to be able to replicate specific failure modes inbound filtering is
more desirable and has been brought up CASSANDRA-15568 since outbound made
testing CAS harder.
I will try to figure out how to deal with that test, ill see if there is any
way to replicate with inbound filtering and if I can't I will try to revert the
inbound filtering logic and try to figure out how to rewrite my tests to not
rely on it.
was (Author: dcapwell):
org.apache.cassandra.distributed.test.PreviewRepairTest uses a blocking filter
to delay the validation message; in trunk we block the MessagingService.send
method and in this patch we do this as part of inbound filtering (this is
performed in the Stage pool). In order for dtest filters to be able to
replicate specific failure modes inbound filtering is more desirable and has
been brought up CASSANDRA-15568 since outbound made testing CAS harder.
I will try to figure out how to deal with that test, ill see if there is any
way to replicate with inbound filtering and if I can't I will try to revert the
inbound filtering logic and try to figure out how to rewrite my tests to not
rely on it.
> Refactor repair coordinator so errors are consistent
> ----------------------------------------------------
>
> Key: CASSANDRA-15564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15564
> Project: Cassandra
> Issue Type: Sub-task
> Components: Consistency/Repair
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> This is to split the change in CASSANDRA-15399 so the refactor is isolated
> out.
> Currently the repair coordinator special cases the exit cases at each call
> site; this makes it so that errors can be inconsistent and there are cases
> where proper complete isn't done (proper notifications, and forgetting to
> update ActiveRepairService).
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
