[
https://issues.apache.org/jira/browse/CASSANDRA-15622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17053391#comment-17053391
]
Michael Semb Wever edited comment on CASSANDRA-15622 at 3/6/20, 12:56 PM:
--------------------------------------------------------------------------
[~blerer], appreciated if you could take a quick glance at the additional
"squash"
[commit|https://github.com/apache/cassandra/commit/cede207a90b5f7061d7d209d07e5c5f5add88d5b]
that's added to the `cassandra_3.11_15622` branch.
It's still trivial changes (and only to the test classes) but it did go a bit
further than what was needed on all the other branches so the review formality
would be appreciated.
Otherwise tests are looking much better now across all the branches (for both
circleci and jenkins)
was (Author: michaelsembwever):
[~blerer], appreciated if you could take a quick glance at the additional
"squash"
[commit|https://github.com/apache/cassandra/commit/cede207a90b5f7061d7d209d07e5c5f5add88d5b]
that's added to the `cassandra_3.11_15622`.
It's still trivial changes (and only to the test classes) but it did go a bit
further than what was needed on all the other branches so the review formality
would be appreciated.
Otherwise tests are looking much better now across all the branches (for both
circleci and jenkins)
> Unit tests throw UnknownHostException trying to use
> `InetAddress.getLocalHost()` instead of `FBUtilities.getLocalAddress()`
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15622
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15622
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x
>
>
> Many of the unit tests in Jenkins fail because of the use of
> {{`InetAddress.getLocalHost()`}} in the test classes.
> The Jenkins agents need a public ipaddress (and a hostname associated to it)
> so the Jenkins master can connect to them (agents can be hosted externally,
> by donating third-parties).
> The call to {{`InetAddress.getLocalHost()`}} can resolve to a hostname that
> can't be looked up.
> Not only it likely not listed in {{`/etc/hosts`}}, but we don't want it to be
> either (in case of accidental external port opening if the hostname points to
> the public ipaddress). (This is also ASF policy on this infrastructure.)
> The unit test code needs to replace these code occurrences with the call to
> {{`FBUtilities.getLocalAddress()`}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
