[
https://issues.apache.org/jira/browse/CASSANDRA-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056538#comment-17056538
]
David Capwell commented on CASSANDRA-15564:
-------------------------------------------
bq. we also need to change the initialization order to make sure outbound
message sending is wrapping fake messaging and not vice versa.
done.
bq. I'm wondering whether we should stick to runInbound in builder, or we
should switch to `filters().inbound()` or something similar, where `filters()`
would return some interface that has `inbound` and `outbound`. This could even
leave most of the things more or less same implementation-wise.
I don't follow, are you asking I rename runInbound to inbound and runOutbound
to outbound? I feel like you are saying more but don't follow.
bq. Should we add a test that ensures the order (in other words, any message
first goes through outbound, and only then through inbound filter)?
I was using the preview repair tests to do that but the test is racy if filters
don't work which make the test pass... aka can't rely on it =(. Ill add a test
> Refactor repair coordinator so errors are consistent
> ----------------------------------------------------
>
> Key: CASSANDRA-15564
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15564
> Project: Cassandra
> Issue Type: Sub-task
> Components: Consistency/Repair
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 16.5h
> Remaining Estimate: 0h
>
> This is to split the change in CASSANDRA-15399 so the refactor is isolated
> out.
> Currently the repair coordinator special cases the exit cases at each call
> site; this makes it so that errors can be inconsistent and there are cases
> where proper complete isn't done (proper notifications, and forgetting to
> update ActiveRepairService).
> [Circle
> CI|https://circleci.com/gh/dcapwell/cassandra/tree/bug%2FrepairCoordinatorJmxConsistency]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
