[ 
https://issues.apache.org/jira/browse/CASSANDRA-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060129#comment-17060129
 ] 

Ryan Svihla edited comment on CASSANDRA-14296 at 3/16/20, 11:23 AM:
--------------------------------------------------------------------

I would say it's likely it got fixed somewhere else long ago. I just ran 
eclipse-warnings from the latest trunk and the output generates no warnings.

{{eclipse-warnings:}}
{{ [echo] Running Eclipse Code Analysis. Output logged to 
/Users/ryansvihla/code/cassandra/build/ecj/eclipse_compiler_checks.txt}}{{BUILD 
SUCCESSFUL}}
{{Total time: 16 seconds}}
{{➜ cassandra git:(trunk) ✗ vim 
/Users/ryansvihla/code/cassandra/build/ecj/eclipse_compiler_checks.txt}}
{{➜ cassandra git:(trunk) ✗ vim 
/Users/ryansvihla/code/cassandra/build/ecj/eclipse_compiler_checks.txt}}
{{➜ cassandra git:(trunk) ✗ cat 
/Users/ryansvihla/code/cassandra/build/ecj/eclipse_compiler_checks.txt}}
{{# 16/03/20 12:17:03 CET}}
{{# Eclipse Compiler for Java(TM) v20160829-0950, 3.12.1, Copyright IBM Corp 
2000, 2015. All rights reserved.}}
{{➜ cassandra git:(trunk) ✗}}


was (Author: rssvihla):
I would say it's likely it got fixed somewhere else long ago. I just ran 
eclipse-warnings from the latest trunk and the output generates no warnings.



eclipse-warnings:
 [echo] Running Eclipse Code Analysis. Output logged to 
/Users/ryansvihla/code/cassandra/build/ecj/eclipse_compiler_checks.txt

BUILD SUCCESSFUL
Total time: 16 seconds
➜ cassandra git:(trunk) ✗ cat 
/Users/ryansvihla/code/cassandra/build/ecj/eclipse_compiler_checks.txt
# 16/03/20 12:17:03 CET
# Eclipse Compiler for Java(TM) v20160829-0950, 3.12.1, Copyright IBM Corp 
2000, 2015. All rights reserved.
➜ cassandra git:(trunk) ✗

> Fix eclipse-warnings introduced by 7544 parameter handling
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-14296
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14296
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Streaming and Messaging
>            Reporter: Ariel Weisberg
>            Priority: Normal
>             Fix For: 4.0
>
>
> There are some Closables that aren't being closed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to