[
https://issues.apache.org/jira/browse/CASSANDRA-15650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063718#comment-17063718
]
David Capwell edited comment on CASSANDRA-15650 at 3/21/20, 2:07 AM:
---------------------------------------------------------------------
This one is weird. Only one code path skips and that only happens if you ask
for a index table, the only other case this could happen is if there are two
hosts defined and only one of them is the coordinator. since I only define 1 I
don't see how the second case happens, so this only makes sense if we skip,
which would require
org.apache.cassandra.service.StorageService#getValidColumnFamilies to return a
empty list (may be some how possible that the keyspace list is empty some how,
and then this defaults to repair all tables, even in this case we should still
fail since the coordinator is the only host present)
was (Author: dcapwell):
This one is weird. Only one code path skips and that only happens if you ask
for a index table, the only other case this could happen is if there are two
hosts defined and only one of them is the coordinator. since I only define 1 I
don't see how the second case happens, so this only makes sense if we skip,
which would require
org.apache.cassandra.service.StorageService#getValidColumnFamilies to return a
empty list.
> Fix flaky test
> org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest
> onlyCoordinator
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15650
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> Test failure:
> https://app.circleci.com/pipelines/github/dcapwell/cassandra/177/workflows/3dff37a5-9bf4-40e2-8d5b-f127b416dc79/jobs/862
> {code}
> [junit-timeout] Testcase:
> onlyCoordinator[SEQUENTIAL/true](org.apache.cassandra.distributed.test.FullRepairCoordinatorFastTest):
> FAILED
> [junit-timeout] nodetool command repair was successful but not expected to
> be. Actual: 0
> [junit-timeout] junit.framework.AssertionFailedError: nodetool command repair
> was successful but not expected to be. Actual: 0
> [junit-timeout] at
> org.apache.cassandra.distributed.api.NodeToolResult$Asserts.failure(NodeToolResult.java:76)
> [junit-timeout] at
> org.apache.cassandra.distributed.test.RepairCoordinatorFast.onlyCoordinator(RepairCoordinatorFast.java:255)
> [junit-timeout] at
> java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [junit-timeout] at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
