[
https://issues.apache.org/jira/browse/CASSANDRA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Capwell updated CASSANDRA-15631:
--------------------------------------
Reviewers: David Capwell, David Capwell (was: David Capwell)
David Capwell, David Capwell
Status: Review In Progress (was: Patch Available)
Did a first pass and overall LGTM; few comments below.
* * [at
line|https://github.com/apache/cassandra/compare/trunk...newkek:15631-trunk#diff-2cccd7bf48b7a9cc113ff564acd802a8R623]
3.15 is out, maybe use that?
* [at
line|https://github.com/apache/cassandra/compare/trunk...newkek:15631-trunk#diff-1dd73505fd4b8d16fb40a4aebb68e5eeR244]
is there a reason you added the round? It slightly changes the original test
behavior; I don't mind, but it is a semantic difference.
* [at
line|https://github.com/apache/cassandra/compare/trunk...newkek:15631-trunk#diff-1dd73505fd4b8d16fb40a4aebb68e5eeL251]
you dropped this assert
* [at
line|https://github.com/apache/cassandra/compare/trunk...newkek:15631-trunk#diff-e75a62e10e716a6aae0c77fe80f6f39cR30]
should we change the assert message to be more clear? This will only print
out the numbers, may be nice to comment that they are object sizes.
Ill try to look closer later. Do you also have a build which shows the tests
passing?
> Add AssertJ test dependency
> ---------------------------
>
> Key: CASSANDRA-15631
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15631
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest, Test/unit
> Reporter: Kevin Gallardo
> Assignee: Kevin Gallardo
> Priority: Normal
> Fix For: 4.0-beta
>
>
> See
> [proposal|https://lists.apache.org/thread.html/rc562ec47578d0ae6f346ba9e3d7469c1cd3f8b521a72ddcb2accc47b%40%3Cdev.cassandra.apache.org%3E].
> The goal is to add [AssertJ|https://assertj.github.io/doc/] to the test
> framework to allow for more comprehensible and easier to write tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
