[
https://issues.apache.org/jira/browse/CASSANDRA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067816#comment-17067816
]
Kevin Gallardo commented on CASSANDRA-15631:
--------------------------------------------
Hey [~dcapwell] thank you very much for looking into it. For some reason I did
not get a notification of your comment and have done some more work on the
branch since then. Notably: I put the AssertJ dependency to 3.15.
bq. at line is there a reason you added the round? It slightly changes the
original test behavior; I don't mind, but it is a semantic difference.
Right, I had rounded because {{measureDeep()}} returns a long and the signature
of {{isLessThan()}} doesn't allow for a double, but instead I should change the
compared value to a double so I don't have to round.
bq. at line you dropped this assert
Not sure which assert you were referring to since the code has changed since
your comment, but tracing back to the line number you linked on trunk points to
the assert on {{session.getSyncingTasks().size()}}. In my branch it was changed
to {{assertThat(session.getSyncingTasks()).isEmpty()}}, so the functionality
should be equivalent. Please let me know if you were referring to another
assert.
bq. at line should we change the assert message to be more clear? This will
only print out the numbers, may be nice to comment that they are object sizes.
Makes sense, will change that.
For CI, you can see the runs at
https://app.circleci.com/pipelines/github/newkek/cassandra?branch=15631-trunk .
Latest run (#17) had a failure that didn't seem related to these changes, and
the test passed when I ran it locally.
> Add AssertJ test dependency
> ---------------------------
>
> Key: CASSANDRA-15631
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15631
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest, Test/unit
> Reporter: Kevin Gallardo
> Assignee: Kevin Gallardo
> Priority: Normal
> Fix For: 4.0-beta
>
>
> See
> [proposal|https://lists.apache.org/thread.html/rc562ec47578d0ae6f346ba9e3d7469c1cd3f8b521a72ddcb2accc47b%40%3Cdev.cassandra.apache.org%3E].
> The goal is to add [AssertJ|https://assertj.github.io/doc/] to the test
> framework to allow for more comprehensible and easier to write tests.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
