[
https://issues.apache.org/jira/browse/CASSANDRA-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068977#comment-17068977
]
Jon Haddad commented on CASSANDRA-15661:
----------------------------------------
Thanks for the quick review Alex!
For a little context - generally what I'm trying to do here is put the right
logging in place so people are able to properly diagnose a cluster's behavior
with regard to correctness and data loss after a problem has occurred, when
they're running the stock config. There were a few cases in the last several
years I could have used the additional logging. None of what was added will
significantly increase the log traffic, but every one of the messages has
significant value, in my opinion.
I replied to each of the comments in the PR. Thanks agin for reviewing so
quickly.
> Improve logging by using more appropriate levels
> -------------------------------------------------
>
> Key: CASSANDRA-15661
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15661
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
> Reporter: Jon Haddad
> Assignee: Jon Haddad
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> There are a number of log statements using logging levels that are a bit too
> conservative. For example:
> * Flushing memtables is currently at debug. This is a relatively rare event
> that is important enough to be INFO
> * When compaction finishes we log the progress at debug
> * Different steps in incremental repair are logged as debug, should be INFO
> * when reaching connection limits in ConnectionLimitHandler.java we log at
> warn rather than error. Since this is a client disconnect it’s more than a
> warning, we’re taking action and disconnecting.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
