[ https://issues.apache.org/jira/browse/CASSANDRA-15582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077588#comment-17077588 ]
Dinesh Joshi commented on CASSANDRA-15582: ------------------------------------------ [~spmallette] thanks for your contribution. I think improving unit test coverage is always welcome. Your groovy script approach to enumerate JMX metrics is also a good one. I think we need to ensure that all possible metrics are generated. How do we ensure that all code paths that generate the metrics are exercised? I would also perhaps add a file with the expected baseline paths that should exist. It would also be helpful to check that the values are the same (within some delta) for those metrics that are comparable. From a maintainability perspective, we should consider using Java as most of us are familiar with it. > 4.0 quality testing: metrics > ---------------------------- > > Key: CASSANDRA-15582 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15582 > Project: Cassandra > Issue Type: Task > Components: Test/dtest > Reporter: Josh McKenzie > Assignee: Romain Hardouin > Priority: Normal > Fix For: 4.0-rc > > > In past releases we've unknowingly broken metrics integrations and introduced > performance regressions in metrics collection and reporting. We strive in 4.0 > to not do that. Metrics should work well! -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org