[ https://issues.apache.org/jira/browse/CASSANDRA-15667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079380#comment-17079380 ]
Ekaterina Dimitrova edited comment on CASSANDRA-15667 at 4/9/20, 2:06 PM: -------------------------------------------------------------------------- Hi Sergio, Thanks for the patch and the broad explanation. I just returned the test [here|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15667] Unfortunately, I am not a committer so someone else should do it. Thanks again! was (Author: e.dimitrova): Hi Sergio, Thanks for the patch and the broad explanation. I just returned the test [here|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15667] Unfortunately, I am not a committer so anyone else should do it. Thanks again! > StreamResultFuture check for completeness is inconsistent, leading to races > --------------------------------------------------------------------------- > > Key: CASSANDRA-15667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15667 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Streaming and Messaging > Reporter: Sergio Bossa > Assignee: Massimiliano Tomassi > Priority: Normal > Fix For: 4.0 > > > {{StreamResultFuture#maybeComplete()}} uses > {{StreamCoordinator#hasActiveSessions()}} to determine if all sessions are > completed, but then accesses each session state via > {{StreamCoordinator#getAllSessionInfo()}}: this is inconsistent, as the > former relies on the actual {{StreamSession}} state, while the latter on the > {{SessionInfo}} state, and the two are concurrently updated with no > coordination whatsoever. > This leads to races, i.e. apparent in some dtest spurious failures, such as > {{TestBootstrap.resumable_bootstrap_test}} in CASSANDRA-15614 cc > [~e.dimitrova]. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org